lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v13 11/13] platform/x86: Intel SGX driver
    On Thu, Sep 06, 2018 at 05:50:01PM -0700, Joe Perches wrote:
    > On Thu, 2018-09-06 at 19:35 +0200, Miguel Ojeda wrote:
    > > > Which one is right and why the kernel tree is polluted with C99-headers
    > > > when they do not pass checkpatch.pl?
    >
    > checkpatch ignores c99 headers since 2016.

    Jarkko was referring to c99 comments for the SPDX license. checkpatch
    explicitly requires c-style comments for headers and assembly files as
    dictated by Documentation/process/license-rules.rst.

    $ grep -r SPDX **/*.h | grep \/\/ | wc -l
    665

    $ grep -r SPDX **/*.S | grep \/\/ | wc -l
    22

    $ git show 9f3a89926d6df
    commit 9f3a89926d6dfc30a4fd1bbcb92cc7b218d3786d
    Author: Rob Herring <robh@kernel.org>
    Date: Tue Apr 10 16:33:13 2018 -0700

    checkpatch.pl: add SPDX license tag check

    Add SPDX license tag check based on the rules defined in
    Documentation/process/license-rules.rst. To summarize, SPDX license
    tags should be on the 1st line (or 2nd line in scripts) using the
    appropriate comment style for the file type.

    Link: http://lkml.kernel.org/r/20180202154026.15298-1-robh@kernel.org
    Signed-off-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Joe Perches <joe@perches.com>
    Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
    Cc: Andy Whitcroft <apw@canonical.com>
    Cc: Joe Perches <joe@perches.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Igor Stoppa <igor.stoppa@huawei.com>
    Cc: Jonathan Corbet <corbet@lwn.net>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index b464a4c3f863..0f022b56f117 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -2257,6 +2257,8 @@ sub process {

    my $camelcase_file_seeded = 0;

    + my $checklicenseline = 1;
    +
    sanitise_line_reset();
    my $line;
    foreach my $rawline (@rawlines) {
    @@ -2448,6 +2450,7 @@ sub process {
    } else {
    $check = $check_orig;
    }
    + $checklicenseline = 1;
    next;
    }

    @@ -2911,6 +2914,30 @@ sub process {
    }
    }

    +# check for using SPDX license tag at beginning of files
    + if ($realline == $checklicenseline) {
    + if ($rawline =~ /^[ \+]\s*\#\!\s*\//) {
    + $checklicenseline = 2;
    + } elsif ($rawline =~ /^\+/) {
    + my $comment = "";
    + if ($realfile =~ /\.(h|s|S)$/) {
    + $comment = '/*';
    + } elsif ($realfile =~ /\.(c|dts|dtsi)$/) {
    + $comment = '//';
    + } elsif (($checklicenseline == 2) || $realfile =~ /\.(sh|pl|py|awk|tc)$/) {
    + $comment = '#';
    + } elsif ($realfile =~ /\.rst$/) {
    + $comment = '..';
    + }
    +
    + if ($comment !~ /^$/ &&
    + $rawline !~ /^\+\Q$comment\E SPDX-License-Identifier: /) {
    + WARN("SPDX_LICENSE_TAG",
    + "Missing or malformed SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
    + }
    + }
    + }
    +
    # check we are in a valid source file if not then ignore this hunk
    next if ($realfile !~ /\.(h|c|s|S|sh|dtsi|dts)$/);


    \
     
     \ /
      Last update: 2018-09-07 19:03    [W:4.382 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site