Messages in this thread Patch in this message | | | From | Igor Stoppa <> | Subject | [PATCH] filesystems: remove unnecessary unlikely() | Date | Fri, 7 Sep 2018 19:14:05 +0300 |
| |
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another.
Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- fs/open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/open.c b/fs/open.c index 0285ce7dbd51..19a9e4b378d3 100644 --- a/fs/open.c +++ b/fs/open.c @@ -750,7 +750,7 @@ static int do_dentry_open(struct file *f, f->f_mode |= FMODE_ATOMIC_POS; f->f_op = fops_get(inode->i_fop); - if (unlikely(WARN_ON(!f->f_op))) { + if (WARN_ON(!f->f_op)) { error = -ENODEV; goto cleanup_all; } -- 2.17.1
| |