Messages in this thread | | | Date | Fri, 7 Sep 2018 09:55:33 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] printk/tracing: Do not trace printk_nmi_enter() |
| |
On Fri, 7 Sep 2018 15:45:32 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> Yes really, we should not muck with the IRQ state from NMI context.
Right, and we didn't. Your patch didn't change anything, but allow for printk_nmi_enter/exit() to be traced by ftrace, but that's wrong to begin with because it ftrace_nmi_enter() hasn't been called yet.
-- Steve
| |