lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Xen-devel] [PATCH] xen/balloon: add runtime control for scrubbing ballooned out pages
From
Date
On 07/09/18 08:51, Jan Beulich wrote:
>>>> On 06.09.18 at 17:33, <marmarek@invisiblethingslab.com> wrote:
>> --- a/include/xen/mem-reservation.h
>> +++ b/include/xen/mem-reservation.h
>> @@ -17,12 +17,17 @@
>>
>> #include <xen/page.h>
>>
>> +#ifdef CONFIG_XEN_SCRUB_PAGES
>> +extern bool xen_scrub_pages;
>> +
>> static inline void xenmem_reservation_scrub_page(struct page *page)
>> {
>> -#ifdef CONFIG_XEN_SCRUB_PAGES
>> - clear_highpage(page);
>> -#endif
>> + if (xen_scrub_pages)
>> + clear_highpage(page);
>> }
>> +#else
>> +static inline void xenmem_reservation_scrub_page(struct page *page) { }
>> +#endif
>
> Wouldn't CONFIG_XEN_SCRUB_PAGES then better become
> CONFIG_XEN_SCRUB_PAGES_DEFAULT, with the value used as
> initializer of xen_scrub_pages?

Yes, I'd like that better.


Juergen

\
 
 \ /
  Last update: 2018-09-07 15:16    [W:0.058 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site