Messages in this thread | | | Date | Fri, 7 Sep 2018 13:04:07 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 0/9] psi: pressure stall information for CPU, memory, and IO v4 |
| |
On Wed, Sep 05, 2018 at 05:43:03PM -0400, Johannes Weiner wrote: > On Tue, Aug 28, 2018 at 01:22:49PM -0400, Johannes Weiner wrote: > > This version 4 of the PSI series incorporates feedback from Peter and > > fixes two races in the lockless aggregator that Suren found in his > > testing and which caused the sample calculation to sometimes underflow > > and record bogusly large samples; details at the bottom of this email. > > Peter, do the changes from v3 look sane to you? > > If there aren't any further objections, I was hoping we could get this > lined up for 4.20.
I suppose it looks ok, there's a few small nits, but nothing big.
I still hate psi_ttwu_dequeue(), but I don't really know what to about that.
So yeah, grudingly acked. Did you want me to pick this up through the scheduler tree since most of this lives there?
| |