lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] xen: avoid crash in disable_hotplug_cpu
Am Fri, 7 Sep 2018 09:48:28 +0200
schrieb Juergen Gross <jgross@suse.com>:

> On 07/09/18 08:30, Olaf Hering wrote:
> > + if (cpu_online(cpu))
> > + return;
> > if (cpu_present(cpu))
> > xen_arch_unregister_cpu(cpu);

> Could you merge the two if conditions?
> if (!cpu_online(cpu) && cpu_present(cpu))
> xen_arch_unregister_cpu(cpu);

Is that any different, beside being wrong, from what the patch actually does?
It would still clear the present bit later on.

Olaf
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-09-07 11:25    [W:0.100 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site