lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 51/67] reset: imx7: Fix always writing bits as 0
    Date
    From: Leonard Crestez <leonard.crestez@nxp.com>

    [ Upstream commit 26fce0557fa639fb7bbc33e31a57cff7df25c3a0 ]

    Right now the only user of reset-imx7 is pci-imx6 and the
    reset_control_assert and deassert calls on pciephy_reset don't toggle
    the PCIEPHY_BTN and PCIEPHY_G_RST bits as expected. Fix this by writing
    1 or 0 respectively.

    The reference manual is not very clear regarding SRC_PCIEPHY_RCR but for
    other registers like MIPIPHY and HSICPHY the bits are explicitly
    documented as "1 means assert, 0 means deassert".

    The values are still reversed for IMX7_RESET_PCIE_CTRL_APPS_EN.

    Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
    Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/reset/reset-imx7.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c
    index 4db177bc89bc..fdeac1946429 100644
    --- a/drivers/reset/reset-imx7.c
    +++ b/drivers/reset/reset-imx7.c
    @@ -80,7 +80,7 @@ static int imx7_reset_set(struct reset_controller_dev *rcdev,
    {
    struct imx7_src *imx7src = to_imx7_src(rcdev);
    const struct imx7_src_signal *signal = &imx7_src_signals[id];
    - unsigned int value = 0;
    + unsigned int value = assert ? signal->bit : 0;

    switch (id) {
    case IMX7_RESET_PCIEPHY:
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-07 02:40    [W:4.807 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site