lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.18 16/88] clk: imx6ul: fix missing of_node_put()
    Date
    From: Nicholas Mc Guire <hofrat@osadl.org>

    [ Upstream commit 11177e7a7aaef95935592072985526ebf0a3df43 ]

    of_find_compatible_node() is returning a device node with refcount
    incremented and must be explicitly decremented after the last use
    which is right after the us in of_iomap() here.

    Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
    Fixes: 787b4271a6a0 ("clk: imx: add imx6ul clk tree support")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/clk/imx/clk-imx6ul.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
    index ba563ba50b40..9f1a40498642 100644
    --- a/drivers/clk/imx/clk-imx6ul.c
    +++ b/drivers/clk/imx/clk-imx6ul.c
    @@ -142,6 +142,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)

    np = of_find_compatible_node(NULL, NULL, "fsl,imx6ul-anatop");
    base = of_iomap(np, 0);
    + of_node_put(np);
    WARN_ON(!base);

    clks[IMX6UL_PLL1_BYPASS_SRC] = imx_clk_mux("pll1_bypass_src", base + 0x00, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels));
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-07 03:00    [W:4.108 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site