lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 36/89] iio: sca3000: Fix missing return in switch
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gustavo A. R. Silva <gustavo@embeddedor.com>

    commit c5b974bee9d2ceae4c441ae5a01e498c2674e100 upstream.

    The IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY case is missing a
    return and will fall through to the default case and errorenously
    return -EINVAL.

    Fix this by adding in missing *return ret*.

    Fixes: 626f971b5b07 ("staging:iio:accel:sca3000 Add write support to the low pass filter control")
    Reported-by: Jonathan Cameron <jic23@kernel.org>
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/accel/sca3000.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/iio/accel/sca3000.c
    +++ b/drivers/iio/accel/sca3000.c
    @@ -797,6 +797,7 @@ static int sca3000_write_raw(struct iio_
    mutex_lock(&st->lock);
    ret = sca3000_write_3db_freq(st, val);
    mutex_unlock(&st->lock);
    + return ret;
    default:
    return -EINVAL;
    }

    \
     
     \ /
      Last update: 2018-09-07 23:57    [W:4.167 / U:0.844 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site