Messages in this thread | | | Date | Fri, 07 Sep 2018 14:46:59 -0700 (PDT) | Subject | Re: [PATCH] ethernet: hnae: add unlikely() to assert() | From | David Miller <> |
| |
From: Igor Stoppa <igor.stoppa@gmail.com> Date: Fri, 7 Sep 2018 20:26:50 +0300
> The assert() condition is likely to be true.
Worse than that is that drivers should not be definiting their own private "assert()" macro.
I'd rather have that fixed instead. We have tons of standard kernel facilities that do what they are trying to do here, without overloading the standard C namespace in this way.
| |