Messages in this thread | | | Date | Fri, 07 Sep 2018 10:35:08 -0700 (PDT) | Subject | Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet | From | David Miller <> |
| |
From: Jakub Kicinski <jakub.kicinski@netronome.com> Date: Fri, 7 Sep 2018 18:36:36 +0200
> On Fri, 7 Sep 2018 09:21:17 -0700, jun qian wrote: >> As you are already in a tasklet, it is unnecessary to call spin_lock_bh. >> >> Signed-off-by: jun qian <hangdianqj@163.com> > > FWIW you should put spaces after the colons. It's generally a good > practice to look at the prefix previous authors used for a given piece > of code with > > git log -- $file_path > > This would be a better subject: > > nfp: replace spin_lock_bh with spin_lock in tasklet callback
Yes, please fix your subject styling.
| |