lkml.org 
[lkml]   [2018]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] block: bfq: swap puts in bfqg_and_blkg_put
From
Date


> Il giorno 06 set 2018, alle ore 10:05, Konstantin Khlebnikov <khlebnikov@yandex-team.ru> ha scritto:
>
> Fix trivial use-after-free. This could be last reference to bfqg.
>

Acked-by: Paolo Valente <paolo.valente@linaro.org>

> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: 8f9bebc33dd7 ("block, bfq: access and cache blkg data only when safe")
> ---
> block/bfq-cgroup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
> index 58c6efa9f9a9..9fe5952d117d 100644
> --- a/block/bfq-cgroup.c
> +++ b/block/bfq-cgroup.c
> @@ -275,9 +275,9 @@ static void bfqg_and_blkg_get(struct bfq_group *bfqg)
>
> void bfqg_and_blkg_put(struct bfq_group *bfqg)
> {
> - bfqg_put(bfqg);
> -
> blkg_put(bfqg_to_blkg(bfqg));
> +
> + bfqg_put(bfqg);
> }
>
> /* @stats = 0 */
>

\
 
 \ /
  Last update: 2018-09-06 19:31    [W:0.044 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site