Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 6 Sep 2018 14:44:01 +0200 | Subject | Re: [PATCH] gpio: ep93xx: fix incorrect array element size check |
| |
On Thu, Sep 6, 2018 at 1:58 PM Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com> > > Currently the while loop checks for the end of the array using > the size of egp->gc rather that the number of elements in the array, > so fix this. Also, perform the array size check first as stylistically > it is always good to bounds check on an array first before referencing > the array (in this case, we're just computing the address of an > element in an array so this is a moot point). > > Fixes: fd935fc421e7 ("gpio: ep93xx: Do not pingpong irq numbers") > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Oh that was really neat code! Thanks a lot.
Patch applied.
Yours, Linus Walleij
| |