lkml.org 
[lkml]   [2018]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v7 2/2]: perf record: enable asynchronous trace writing
From
Date


On 06.09.2018 14:04, Jiri Olsa wrote:
> On Wed, Sep 05, 2018 at 10:39:25AM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> +
>> static int process_synthesized_event(struct perf_tool *tool,
>> union perf_event *event,
>> struct perf_sample *sample __maybe_unused,
>> @@ -130,12 +215,28 @@ static int process_synthesized_event(struct perf_tool *tool,
>> return record__write(rec, event, event->header.size);
>> }
>>
>> -static int record__pushfn(void *to, void *bf, size_t size)
>> +static int record__pushfn(void *to, struct aiocb *cblock, void *data, size_t size)
>> {
>> + off_t off;
>> struct record *rec = to;
>> + int ret, trace_fd = rec->session->data->file.fd;
>>
>> rec->samples++;
>> - return record__write(rec, bf, size);
>> +
>> + off =
>> + lseek(trace_fd, 0, SEEK_CUR);
>
> please keep that on the same line.. also, please run this
> patchset through the scripts/checkpatch.pl
>
> don't worry about the 'line over 80 characters' errors,
> but the rest will be nice to have ;-)

ok! :)

>
> jirka
>

\
 
 \ /
  Last update: 2018-09-06 13:59    [W:0.065 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site