Messages in this thread | | | Date | Thu, 6 Sep 2018 13:04:13 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v7 2/2]: perf record: enable asynchronous trace writing |
| |
On Wed, Sep 05, 2018 at 10:39:25AM +0300, Alexey Budankov wrote:
SNIP
> + > static int process_synthesized_event(struct perf_tool *tool, > union perf_event *event, > struct perf_sample *sample __maybe_unused, > @@ -130,12 +215,28 @@ static int process_synthesized_event(struct perf_tool *tool, > return record__write(rec, event, event->header.size); > } > > -static int record__pushfn(void *to, void *bf, size_t size) > +static int record__pushfn(void *to, struct aiocb *cblock, void *data, size_t size) > { > + off_t off; > struct record *rec = to; > + int ret, trace_fd = rec->session->data->file.fd; > > rec->samples++; > - return record__write(rec, bf, size); > + > + off = > + lseek(trace_fd, 0, SEEK_CUR);
please keep that on the same line.. also, please run this patchset through the scripts/checkpatch.pl
don't worry about the 'line over 80 characters' errors, but the rest will be nice to have ;-)
jirka
| |