Messages in this thread | | | Date | Thu, 6 Sep 2018 16:51:00 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 2/2] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK |
| |
On Thu, Sep 06, 2018 at 10:11:59AM +0200, Ard Biesheuvel wrote: > > That way, we will almost certainly oops on a NULL pointer dereference > right after, but we at least the stack corruption.
A crash is just as bad as a BUG_ON.
Is this even a real problem? Do we have any users of this construct that is using it on async algorithms?
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |