lkml.org 
[lkml]   [2018]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] mm: Create non-atomic version of SetPageReserved for init use
On Wed 05-09-18 14:13:34, Alexander Duyck wrote:
[...]

just a nit

> @@ -1231,7 +1231,8 @@ void __meminit reserve_bootmem_region(phys_addr_t start, phys_addr_t end)
> /* Avoid false-positive PageTail() */
> INIT_LIST_HEAD(&page->lru);
>
> - SetPageReserved(page);
> + /* no need for atomic set_bit at init time */
> + __SetPageReserved(page);

OK but I guess it would be much more clear to say
/*
* no need for atomic set_bit because the struct
* page is not visible yet so nobody should
* access it yet.
*/
> }
> }
> }
--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2018-09-06 07:51    [W:1.046 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site