Messages in this thread | | | Date | Wed, 5 Sep 2018 12:03:51 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 2/3] RISC-V: Use Linux logical cpu number instead of hartid |
| |
On Tue, Sep 04, 2018 at 02:43:13PM -0700, Atish Patra wrote: > On 9/4/18 2:36 PM, Christoph Hellwig wrote: > > On Tue, Sep 04, 2018 at 01:35:10PM -0700, Atish Patra wrote: > > > sure. How about this ? > > > > That would work, but why not just keep calling sbi_remove_sfence_vma > > directly from flush_tlb_all? > > > I guess that's fine too. I just wanted to keep all flush_tlb_* same format > to make it more coherent.
I'd just keep it simple by calling directly. While the compiler would probably optimize away the branch in an inline function we can just avoid it entirely that way.
| |