lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address
    On Wed, Sep 05, 2018 at 12:04:36PM -0500, Rob Herring wrote:
    > On Wed, Sep 5, 2018 at 11:00 AM Mike Rapoport <rppt@linux.vnet.ibm.com> wrote:
    > >
    > > The conversion is done using
    > >
    > > sed -i 's@memblock_virt_alloc@memblock_alloc@g' \
    > > $(git grep -l memblock_virt_alloc)
    >
    > What's the reason to do this? It seems like a lot of churn even if a
    > mechanical change.

    I felt that memblock_virt_alloc_ is too long for a prefix, e.g:
    memblock_virt_alloc_node_nopanic, memblock_virt_alloc_low_nopanic.

    And for consistency I've changed the memblock_virt_alloc as well.


    > Rob
    >

    --
    Sincerely yours,
    Mike.

    \
     
     \ /
      Last update: 2018-09-05 19:21    [W:4.418 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site