Messages in this thread | | | From | Kees Cook <> | Date | Tue, 4 Sep 2018 17:16:31 -0700 | Subject | Re: [GIT PULL] s390 patches for the 4.19 merge window #2 |
| |
On Fri, Aug 24, 2018 at 12:42 AM, Martin Schwidefsky <schwidefsky@de.ibm.com> wrote: > Harald Freudenberger (5): > s390/zcrypt: hex string mask improvements for apmask and aqmask.
This (and an earlier 2017 commit) adds VLAs, which are being removed[1] from the kernel:
drivers/s390/crypto/ap_bus.c:980:3: warning: ISO C90 forbids variable length array ‘clrm’ [-Wvla] drivers/s390/crypto/ap_bus.c:981:3: warning: ISO C90 forbids variable length array ‘setm’ [-Wvla] drivers/s390/crypto/ap_bus.c:995:3: warning: ISO C90 forbids variable length array ‘setm’ [-Wvla]
static int process_mask_arg(const char *str, unsigned long *bitmap, int bits, struct mutex *lock) ... DECLARE_BITMAP(clrm, bits); DECLARE_BITMAP(setm, bits);
Can someone please adjust this to make these fixed size again?
Thanks!
-Kees
[1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
-- Kees Cook Pixel Security
| |