Messages in this thread | | | From | Ocean HY1 He <> | Subject | RE: [External] Re: [PATCH v2] libnvdimm, region_devs: stop NDD_ALIASING bit test if one test pass | Date | Wed, 5 Sep 2018 03:26:29 +0000 |
| |
> -----Original Message----- > From: Dan Williams <dan.j.williams@intel.com> > Sent: Tuesday, September 04, 2018 11:58 PM > To: Ocean He <oceanhehy@gmail.com> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>; Vishal L Verma > <vishal.l.verma@intel.com>; Dave Jiang <dave.jiang@intel.com>; linux- > nvdimm <linux-nvdimm@lists.01.org>; Linux Kernel Mailing List <linux- > kernel@vger.kernel.org>; Ocean HY1 He <hehy1@lenovo.com> > Subject: [External] Re: [PATCH v2] libnvdimm, region_devs: stop > NDD_ALIASING bit test if one test pass > > On Tue, Sep 4, 2018 at 3:47 AM, Ocean He <oceanhehy@gmail.com> wrote: > > From: Ocean He <hehy1@lenovo.com> > > > > There is no need to finish entire loop to execute NDD_ALIASING bit test > > against every nvdimm->flags. > > Of course there is. I see nothing stopping someone mixing an NVDIMM > that supports labels with one that doesn't. Hi Dan, Thanks for your comments.
I only have NVDIMM which supports label, so I could not do this type test yet. As I understand your words, in mixing status, the nstype would be ND_DEVICE_NAMESPACE_PMEM if one NVDIMM supports labels. Am I right?
By the way, do you think my patch is valuable to save a few cpu cycles here?
Ocean. > If anything I think we > need fixes to make sure this operates correctly to force disable > BLK-mode capactiy when the PMEM capacity is interleaved with a > label-less NVDIMM. I am trying to translate your words to test steps, please correct me for misunderstanding. #1. Prepare 2 NVDIMMs which has no label capacity. #2. Create a region which has PMEM capacity and interleaved. ipmctl create -f -goal -socket 0x1 PersistentMemoryType=AppDirect #3. Create a BLK-mode capacity namespace, then this namespace should be "force disable" ? ndctl create-namespace -r region1 -s 1g -t pmem -m sector
Ocean.
| |