lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 15/16] driver/edac: enable Hygon support to AMD64 EDAC driver
Date
On 2018/9/5 18:44, Borislav Petkov wrote:
> Subject should be:
>
> EDAC, amd64: Add Hygon Dhyana support

Thanks for the correction.

>> + case 0x18:
>> + fam_type = &family_types[HYGON_F18_CPUS];
>> + pvt->ops = &family_types[HYGON_F18_CPUS].ops;
>> + break;
>> +
>
> You can use the F17_CPUS array element here and overwrite the ->ctl_name
> string only. No need to define [HYGON_F18_CPUS] above... yet.

All right, the way reusing F17_CPUS will also minimize the code
modification.

>> +#define PCI_DEVICE_ID_HYGON_18H_DF_F0 0x1460
>> +#define PCI_DEVICE_ID_HYGON_18H_DF_F6 0x1466
>
> As in the previous patch - use the AMD defines.

Will remove them in next version of patches.

--
Regards,
Pu Wen

\
 
 \ /
  Last update: 2018-09-05 15:04    [W:0.602 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site