Messages in this thread | | | Subject | Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c | From | Michael Straube <> | Date | Wed, 5 Sep 2018 13:44:43 +0200 |
| |
On 9/5/18 10:13 AM, Dan Carpenter wrote: > On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote: >> >> case LED_CTL_SITE_SURVEY: >> - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv, _FW_LINKED))) { >> - ; >> - } else if (!pLed->bLedScanBlinkInProgress) { >> + if (!pLed->bLedScanBlinkInProgress) { > > I think you have introduced a bug...
Ah yes I see now, thanks. Would it be ok to merge the conditions in a single if?
if ((!pmlmepriv->LinkDetectInfo.bBusyTraffic || !check_fwstate(pmlmepriv, _FW_LINKED)) && !pLed->bLedScanBlinkInProgress) {
regards, Michael
| |