Messages in this thread | | | Date | Mon, 03 Sep 2018 21:23:43 -0700 (PDT) | Subject | Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition | From | David Miller <> |
| |
From: "Michael S. Tsirkin" <mst@redhat.com> Date: Mon, 3 Sep 2018 23:11:11 -0400
> On Tue, Sep 04, 2018 at 11:08:40AM +0800, Jason Wang wrote: >> >> >> On 2018年09月04日 10:22, Michael S. Tsirkin wrote: >> > On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote: >> > > The _IOC_READ flag fits this ioctl request more because this request >> > > actually only writes to, but doesn't read from userspace. >> > > See NOTEs in include/uapi/asm-generic/ioctl.h for more information. >> > > >> > > Fixes: 429711aec282 ("vhost: switch to use new message format") >> > > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> >> > Hmm it does make sense, and it's not too late to fix this up. >> > Jason, what's your take on this? Was _IOW intentional? >> >> My bad, not intentional. And I agree that fixing this is not too late. >> >> So >> >> Acked-by: Jason Wang <jasowang@redhat.com> > > > OK then > > Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks everyone.
| |