lkml.org 
[lkml]   [2018]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 2/4] iio: gyro: add device tree support for fxas21002c
    On Tue, Sep 4, 2018 at 10:06 PM Afonso Bordado <afonsobordado@az8.co> wrote:
    >
    > This patch adds device tree support for the fxas21002c driver, including
    > bindings.
    >
    > Signed-off-by: Afonso Bordado <afonsobordado@az8.co>

    > +#ifdef CONFIG_OF

    > +#endif

    Please, remove this ifdef...

    > + .of_match_table = of_match_ptr(fxas21002c_of_ids),

    ...and do not use of_match_ptr() macro.

    This prevents to use device on embedded ACPI enabled devices,

    > },
    > .probe = fxas21002c_probe,
    > .id_table = fxas21002c_id,
    > --
    > 2.18.0
    >
    >


    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2018-09-04 21:14    [W:3.083 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site