Messages in this thread | | | Subject | Re: [PATCH v6 1/2]: perf util: map data buffer for preserving collected data | From | Alexey Budankov <> | Date | Tue, 4 Sep 2018 20:50:28 +0300 |
| |
Hi,
On 04.09.2018 20:34, Andi Kleen wrote: >> .sample = process_sample_event, >> @@ -1678,6 +1680,8 @@ static struct option __record_options[] = { >> "signal"), >> OPT_BOOLEAN(0, "dry-run", &dry_run, >> "Parse options then exit"), >> + OPT_INTEGER(0, "aio", &record.opts.nr_cblocks, >> + "asynchronous trace write operations (min: 1, max: 32, default: 2)"), > > would need to be documented in the manpage. But I would rather make it an > ~/.perfconfig option
Yep, make sense, it requires to be configurable w/o recompilation and at the same time its meaning is not obvious to be on the command line for a user.
> > > -Andi >
| |