lkml.org 
[lkml]   [2018]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/29] staging: bcm2835-audio: Kill unused spinlock
    Date
    The alsa_stream->lock is never used.  Kill it.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    ---
    drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 --
    drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 --
    2 files changed, 4 deletions(-)

    diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
    index 00c2abab4bba..fc1b345d206c 100644
    --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
    +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
    @@ -128,8 +128,6 @@ static int snd_bcm2835_playback_open_generic(
    alsa_stream->substream = substream;
    alsa_stream->idx = idx;

    - spin_lock_init(&alsa_stream->lock);
    -
    err = bcm2835_audio_open(alsa_stream);
    if (err) {
    kfree(alsa_stream);
    diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
    index 2a9f3d6c10dc..20f5ff1649e6 100644
    --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
    +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
    @@ -119,8 +119,6 @@ struct bcm2835_alsa_stream {
    struct snd_pcm_substream *substream;
    struct snd_pcm_indirect pcm_indirect;

    - spinlock_t lock;
    -
    int draining;

    int channels;
    --
    2.18.0
    \
     
     \ /
      Last update: 2018-09-04 18:01    [W:4.336 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site