lkml.org 
[lkml]   [2018]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array
    Hi Janusz,

    Thank you for the patch! Yet something to improve:

    [auto build test ERROR on gpio/for-next]
    [also build test ERROR on v4.19-rc2 next-20180831]
    [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

    url: https://github.com/0day-ci/linux/commits/Janusz-Krzysztofik/gpiolib-speed-up-GPIO-array-processing/20180903-174241
    base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
    config: arm-cns3420vb_defconfig (attached as .config)
    compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
    reproduce:
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # save the attached .config to linux build tree
    GCC_VERSION=7.2.0 make.cross ARCH=arm
    :::::: branch date: 5 hours ago
    :::::: commit date: 5 hours ago

    All errors (new ones prefixed by >>):

    drivers/mmc/core/pwrseq_simple.c: In function 'mmc_pwrseq_simple_set_gpios_value':
    >> drivers/mmc/core/pwrseq_simple.c:49:13: error: passing argument 3 of 'gpiod_set_array_value_cansleep' from incompatible pointer type [-Werror=incompatible-pointer-types]
    value_bitmap);
    ^~~~~~~~~~~~
    In file included from drivers/mmc/core/pwrseq_simple.c:18:0:
    include/linux/gpio/consumer.h:400:20: note: expected 'int *' but argument is of type 'long unsigned int *'
    static inline void gpiod_set_array_value_cansleep(unsigned int array_size,
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cc1: some warnings being treated as errors

    # https://github.com/0day-ci/linux/commit/00db98568b73a7b04c5120e5b87934c7355cc015
    git remote add linux-review https://github.com/0day-ci/linux
    git remote update linux-review
    git checkout 00db98568b73a7b04c5120e5b87934c7355cc015
    vim +/gpiod_set_array_value_cansleep +49 drivers/mmc/core/pwrseq_simple.c

    5b96fea73 Srinivas Kandagatla 2016-04-14 36
    934f1f483 Javier Martinez Canillas 2015-01-29 37 static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq,
    934f1f483 Javier Martinez Canillas 2015-01-29 38 int value)
    934f1f483 Javier Martinez Canillas 2015-01-29 39 {
    ce0372758 Javier Martinez Canillas 2015-09-21 40 struct gpio_descs *reset_gpios = pwrseq->reset_gpios;
    64a67d476 Martin Fuzzey 2016-01-20 41
    64a67d476 Martin Fuzzey 2016-01-20 42 if (!IS_ERR(reset_gpios)) {
    486e66613 Tobin C. Harding 2018-03-26 43 int nvalues = reset_gpios->ndescs;
    00db98568 Janusz Krzysztofik 2018-09-01 44 DECLARE_BITMAP(value_bitmap, nvalues);
    934f1f483 Javier Martinez Canillas 2015-01-29 45
    00db98568 Janusz Krzysztofik 2018-09-01 46 *value_bitmap = value;
    486e66613 Tobin C. Harding 2018-03-26 47
    00db98568 Janusz Krzysztofik 2018-09-01 48 gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc,
    00db98568 Janusz Krzysztofik 2018-09-01 @49 value_bitmap);
    64a67d476 Martin Fuzzey 2016-01-20 50 }
    934f1f483 Javier Martinez Canillas 2015-01-29 51 }
    934f1f483 Javier Martinez Canillas 2015-01-29 52

    ---
    0-DAY kernel test infrastructure Open Source Technology Center
    https://lists.01.org/pipermail/kbuild-all Intel Corporation
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2018-09-04 17:16    [W:4.039 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site