Messages in this thread | | | Subject | Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin | From | "Andrew F. Davis" <> | Date | Tue, 4 Sep 2018 08:35:09 -0500 |
| |
On 09/02/2018 11:54 PM, Shawn Guo wrote: > On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote: >> The correct DT property for specifying a GPIO used for reset >> is "reset-gpios", fix this here. >> >> Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards") > > This Fixes tag and word 'Fix' in subject is inappropriate to me, as you > are not fixing something wrong from the beginning, but actually > replacing a deprecated property with new one. >
reset-gpios was standard before this driver got it backwards, but it also wasn't required to be one way or the other as far as I can tell, so I can see your point that this isn't technically "broken". I have no preference, so I'll change the subject and drop the fixes for v2.
Andrew
> Shawn > >> >> Signed-off-by: Andrew F. Davis <afd@ti.com> >> --- >> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> index 7fff3717cf7c..a0f5cfda0055 100644 >> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> @@ -384,7 +384,7 @@ >> AVDD-supply = <®_3p3v>; >> IOVDD-supply = <®_3p3v>; >> DVDD-supply = <&vgen4_reg>; >> - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>; >> + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>; >> }; >> >> accel@1c { >> @@ -572,7 +572,7 @@ >> AVDD-supply = <®_3p3v>; >> IOVDD-supply = <®_3p3v>; >> DVDD-supply = <&vgen4_reg>; >> - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>; >> + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; >> }; >> >> touchscreen@20 { >> -- >> 2.18.0 >>
| |