lkml.org 
[lkml]   [2018]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/25] tty: Change return type to void
    From
    Date
    Hello!

    On 9/4/2018 5:44 AM, Jaejoong Kim wrote:

    > Many drivers with tty use the tty_stand_install(). But, there is no
    > need to handle the error, since it always returns 0. So, change the
    > return type of tty_standard_install() and tty_port_install() to void
    > type and remove unnecessary exception handling where we use these
    > functions.
    >
    > Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
    > ---
    > drivers/tty/tty_io.c | 10 ++++++----
    > drivers/tty/tty_port.c | 4 ++--
    > include/linux/tty.h | 4 ++--
    > 3 files changed, 10 insertions(+), 8 deletions(-)
    >
    [...]
    > diff --git a/include/linux/tty.h b/include/linux/tty.h
    > index c56e397..63cdac1 100644
    > --- a/include/linux/tty.h
    > +++ b/include/linux/tty.h
    > @@ -556,7 +556,7 @@ extern struct tty_struct *tty_init_dev(struct tty_driver *driver, int idx);
    > extern void tty_release_struct(struct tty_struct *tty, int idx);
    > extern int tty_release(struct inode *inode, struct file *filp);
    > extern void tty_init_termios(struct tty_struct *tty);
    > -extern int tty_standard_install(struct tty_driver *driver,
    > +extern void tty_standard_install(struct tty_driver *driver,
    > struct tty_struct *tty);
    >
    > extern struct mutex tty_mutex;
    > @@ -688,7 +688,7 @@ extern int tty_port_close_start(struct tty_port *port,
    > extern void tty_port_close_end(struct tty_port *port, struct tty_struct *tty);
    > extern void tty_port_close(struct tty_port *port,
    > struct tty_struct *tty, struct file *filp);
    > -extern int tty_port_install(struct tty_port *port, struct tty_driver *driver,
    > +extern void tty_port_install(struct tty_port *port, struct tty_driver *driver,
    > struct tty_struct *tty);

    You need to update all the callers in the same patch -- the kernel must
    remain buildable after each patch but you seem to have spread that update
    among a lot of patches..

    [...]

    MBR, Sergei

    \
     
     \ /
      Last update: 2018-09-04 12:45    [W:4.251 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site