Messages in this thread | | | From | Sathya Perla <> | Date | Tue, 4 Sep 2018 11:31:13 +0530 | Subject | Re: [PATCH net-next] bnxt_en: Properly get address type of encapsulation IP headers |
| |
On Sat, Sep 1, 2018 at 2:56 PM YueHaibing <yuehaibing@huawei.com> wrote: > > gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c: In function 'bnxt_tc_parse_flow': > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:186:6: warning: > variable 'addr_type' set but not used [-Wunused-but-set-variable] > > As done elsewhere in TC/flower offload code, the address type of > the encapsulation IP headers should be realized accroding to the > addr_type field of the encapsulation control dissector key. ... > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > index 092c817..5c625e5 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c > @@ -242,7 +242,7 @@ static int bnxt_tc_parse_flow(struct bnxt *bp, > flow->l2_key.num_vlans = 1; > } > > - if (dissector_uses_key(dissector, FLOW_DISSECTOR_KEY_IPV4_ADDRS)) {
__skb_flow_dissect() (in net/core/flow_dissector.c) uses the same construct. So, can you clarify what you are trying to fix here functionally. Thanks.
| |