Messages in this thread | | | Subject | Re: [PATCH net-next] net: caif: fix return type of ndo_start_xmit function | From | YueHaibing <> | Date | Sun, 30 Sep 2018 09:52:55 +0800 |
| |
On 2018/9/30 2:38, David Miller wrote: > From: YueHaibing <yuehaibing@huawei.com> > Date: Wed, 26 Sep 2018 17:27:05 +0800 > >> @@ -1014,7 +1014,7 @@ static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev) >> int prio; >> >> if (!dev) >> - return -EINVAL; >> + return NETDEV_TX_BUSY; >> >> cfhsi = netdev_priv(dev); >> > > Even though the return type of ndo_start_xmit is netdev_tx_t, negative error codes are > still allowed I believe.
I missed this and do the wrong thing.
> > Look, reviewing these are pretty stressful for me, because you aren't documenting your > changes and in many cases the transformations look incorrect. >
I'm really sorry for this.
> I'm tossing the rest of your changes in this area for now, sorry. > > Please double check your work and resubmit this at some time in the not-too-near > future. > > Thank you. > > . >
| |