Messages in this thread | | | From | Dmitry Safonov <> | Subject | [PATCHv2 0/4] tty: Hold write ldisc sem in tty_reopen() | Date | Mon, 3 Sep 2018 17:52:53 +0100 |
| |
The first two fixes are worth to have in stables as we've hit it on v4.9 stable.
And for linux-next - adding lockdep asserts for line discipline changing code, verifying that write ldisc sem will be held forthwith.
Changes since v1: - Added tested-by/reported-by tags - Dropped 3/4 (locking tty pair for lockdep sake), Because of that - not adding lockdep_assert_held() in tty_ldisc_open() - Added 4/4 cleanup to inc tty->count only on success of tty_ldisc_reinit() - lock ldisc without (5*HZ) timeout in tty_reopen()
v1 link: lkml.kernel.org/r/<20180829022353.23568-1-dima@arista.com>
Huuge cc list: Cc: Daniel Axtens <dja@axtens.net> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Michael Neuling <mikey@neuling.org> Cc: Mikulas Patocka <mpatocka@redhat.com> Cc: Nathan March <nathan@gt.net> Cc: Pasi Kärkkäinen <pasik@iki.fi> Cc: Peter Hurley <peter@hurleysoftware.com> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> Cc: Tan Xiaojun <tanxiaojun@huawei.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> (please, ignore if I Cc'ed you mistakenly)
Dmitry Safonov (4): tty: Drop tty->count on tty_reopen() failure tty: Hold tty_ldisc_lock() during tty_reopen() tty/lockdep: Add ldisc_sem asserts tty: Simplify tty->count math in tty_reopen()
drivers/tty/tty_io.c | 12 ++++++++---- drivers/tty/tty_ldisc.c | 5 +++++ 2 files changed, 13 insertions(+), 4 deletions(-)
-- 2.13.6
| |