Messages in this thread | | | Date | Mon, 3 Sep 2018 15:33:58 +0200 | From | Quentin Schulz <> | Subject | Re: [PATCH net-next v2 6/7] dt-bindings: net: phy: mscc: vsc8531: remove compatible from required properties |
| |
Hi Andrew,
On Mon, Sep 03, 2018 at 03:30:20PM +0200, Andrew Lunn wrote: > On Mon, Sep 03, 2018 at 10:48:52AM +0200, Quentin Schulz wrote: > > Compatible isn't a required property for PHYs so let's remove it from > > the binding DT of the VSC8531 PHYs. > > Hi Quentin > > It is actually a optional property. So you could move it into that > section of the binding documentation. But removing it is also O.K. >
It's a property that is already defined in Documentation/devicetree/bindings/net/phy.txt
I don't think it's actually useful to redefine it there (on the same principle that we don't redefine/re-explain the reg property).
What do we do? Do I put it in optional properties and refer to the aforementioned doc or do I just remove it as it's done in this patch?
Thanks, Quentin [unhandled content-type:application/pgp-signature] | |