Messages in this thread | | | Subject | Re: [PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs | From | "Zhu, Yi Xin" <> | Date | Mon, 3 Sep 2018 18:52:21 +0800 |
| |
On 9/1/2018 1:13 AM, Stephen Boyd wrote: > Quoting Zhu, Yi Xin (2018-08-29 03:34:26) >>>>>> +} >>>>>> + >>>>>> +CLK_OF_DECLARE(intel_grx500_cgu, "intel,grx500-cgu", grx500_clk_init); >>>>> Any reason a platform driver can't be used instead of CLK_OF_DECLARE()? >>>> It provides CPU clock which is used in early boot stage. >>>> >>> Ok. What is the CPU clock doing in early boot stage? Some sort of timer >>> frequency? If the driver can be split into two pieces, one to handle the >>> really early stuff that must be in place to get timers up and running >>> and the other to register the rest of the clks that aren't critical from >>> a regular platform driver it would be good. That's preferred model if >>> something is super critical. >>> >> Just to make sure my approach is same as you think. >> >> In the driver, there's two clock registrations. >> >> - One through CLK_OF_DECLARE for early stage clocks. >> >> - The other via platform driver for the non-critical clocks. > You can use the same DT node for both parts, no need to split the node > into two and use syscon here. > Thank you.
Will use CLK_OF_DECLARE_DRIVER to use the same DT node.
| |