Messages in this thread | | | From | Christian Brauner <> | Date | Mon, 3 Sep 2018 11:32:22 +0200 | Subject | Re: [PATCH net-next 0/5] rtnetlink: add IFA_IF_NETNSID for RTM_GETADDR |
| |
On Mon, Sep 03, 2018 at 09:50:00AM +0200, Nicolas Dichtel wrote: > Le 02/09/2018 à 11:58, Jiri Benc a écrit : > > On Sat, 1 Sep 2018 20:47:05 +0200, Christian Brauner wrote: > >> Sorry for the late reply. Yup, sounds good to me. > >> But maybe IFA_TARGET_NETNSID to indicate that we're talking network > >> namespaces here? Seems to me that NSID might give the wrong impression. > >> I'll send v1 soon. I expect tomorrow or sometime next week. > > > > On the other hand, we currently have IFLA_IF_NETNSID for the link > > operations. IFA_IF_NETNSID is more consistent with the existing > > attribute. It may be confusing to authors of user space programs to > > have attribute names doing the same thing constructed differently for > > different calls (IFLA_IF_NETNSID and IFA_TARGET_NETNSID). > Yep, I also thought to this. It had sense because it was the link family. > What about adding an alias (#define IFLA_TARGET_NETNSID IFLA_IF_NETNSID) in the > uapi to better document this?
Sounds good to me.
| |