Messages in this thread | | | Date | Tue, 4 Sep 2018 00:41:27 +0200 | From | Dominique Martinet <> | Subject | Re: [PATCH] 9p: Rename req to rreq |
| |
Tomas Bortoli wrote on Mon, Sep 03, 2018: > Subject: Re: [PATCH] 9p: Rename req to rreq
I feel this is a bit too vague, how about either of these? '9p: Rename req to rreq in trans_fd' or '9p/fd: Rename req to rreq'
We still have plenty of 'req' in client.c and all other transports, so it would feel like a lie otherwise :)
> In struct p9_conn, rename req to rreq as it is used by the read routine. > > Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com> > Suggested-by: Jun Piao <piaojun@huawei.com>
Nitpick on title aside LGTM, I've picked this up for linux-next
-- Dominique
| |