lkml.org 
[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 008/165] nl80211: Add a missing break in parse_station_flags
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bernd Edlinger <bernd.edlinger@hotmail.de>

    [ Upstream commit 5cf3006cc81d9aa09a10aa781fc065546b12919d ]

    I was looking at usually suppressed gcc warnings,
    [-Wimplicit-fallthrough=] in this case:

    The code definitely looks like a break is missing here.
    However I am not able to test the NL80211_IFTYPE_MESH_POINT,
    nor do I actually know what might be :)
    So please use this patch with caution and only if you are
    able to do some testing.

    Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
    [johannes: looks obvious enough to apply as is, interesting
    though that it never seems to have been a problem]
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/wireless/nl80211.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/wireless/nl80211.c
    +++ b/net/wireless/nl80211.c
    @@ -4186,6 +4186,7 @@ static int parse_station_flags(struct ge
    params->sta_flags_mask = BIT(NL80211_STA_FLAG_AUTHENTICATED) |
    BIT(NL80211_STA_FLAG_MFP) |
    BIT(NL80211_STA_FLAG_AUTHORIZED);
    + break;
    default:
    return -EINVAL;
    }

    \
     
     \ /
      Last update: 2018-09-03 19:48    [W:4.158 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site