Messages in this thread | | | Date | Mon, 3 Sep 2018 12:54:28 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin |
| |
On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote: > The correct DT property for specifying a GPIO used for reset > is "reset-gpios", fix this here. > > Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")
This Fixes tag and word 'Fix' in subject is inappropriate to me, as you are not fixing something wrong from the beginning, but actually replacing a deprecated property with new one.
Shawn
> > Signed-off-by: Andrew F. Davis <afd@ti.com> > --- > arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > index 7fff3717cf7c..a0f5cfda0055 100644 > --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > @@ -384,7 +384,7 @@ > AVDD-supply = <®_3p3v>; > IOVDD-supply = <®_3p3v>; > DVDD-supply = <&vgen4_reg>; > - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>; > }; > > accel@1c { > @@ -572,7 +572,7 @@ > AVDD-supply = <®_3p3v>; > IOVDD-supply = <®_3p3v>; > DVDD-supply = <&vgen4_reg>; > - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; > }; > > touchscreen@20 { > -- > 2.18.0 >
| |