lkml.org 
[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 127/165] udl-kms: fix crash due to uninitialized memory
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mikulas Patocka <mpatocka@redhat.com>

    commit 09a00abe3a9941c2715ca83eb88172cd2f54d8fd upstream.

    We must use kzalloc when allocating the fb_deferred_io structure.
    Otherwise, the field first_io is undefined and it causes a crash.

    Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/udl/udl_fb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/udl/udl_fb.c
    +++ b/drivers/gpu/drm/udl/udl_fb.c
    @@ -221,7 +221,7 @@ static int udl_fb_open(struct fb_info *i

    struct fb_deferred_io *fbdefio;

    - fbdefio = kmalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);
    + fbdefio = kzalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);

    if (fbdefio) {
    fbdefio->delay = DL_DEFIO_WRITE_DELAY;

    \
     
     \ /
      Last update: 2018-09-03 19:46    [W:4.491 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site