lkml.org 
[lkml]   [2018]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V6 03/33] csky: Kernel booting
On Fri, Sep 28, 2018 at 09:13:05AM -0700, Christoph Hellwig wrote:
> > +phys_addr_t __init_memblock memblock_end_of_REG0(void)
> > +{
> > + return (memblock.memory.regions[0].base + memblock.memory.regions[0].size);
> > +}
>
> No need for the braces.
Ok.

> > + if (memblock.memory.cnt > 1) {
> > + zone_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1())
- min_low_pfn;
> > + zhole_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1())
- max_low_pfn;
>
> Please brake lines after 80 characters.
Ok.
>
> > + pr_info("C-SKY: https://github.com/c-sky/csky-linux\n");
>
> I don't think this belongs into the kernel log.
Ok, remove it.

Best Regards
Guo Ren

\
 
 \ /
  Last update: 2018-09-29 19:11    [W:0.185 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site