Messages in this thread | | | From | John Stultz <> | Date | Fri, 28 Sep 2018 16:32:33 -0700 | Subject | Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only |
| |
On Thu, Sep 6, 2018 at 6:01 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tables. > > Some boards just auto-enumerate their fixed regulator platform devices > and I have assumed they get names like "fixed-regulator.0" but it's > pretty hard to guess this. I need some testing from board maintainers to > be sure. Other boards are straight forward, using just plain > "fixed-regulator" (ID -1) or "fixed-regulator.1" hammering down the > device ID.
Hey Linus, Anders recently noted a regression in -next when running HiKey, where USB fails to function. I took a look and could reproduce this as well, and after some unsuccessful muddling about in the usb changes, I bisected it down to your commit here (specifically efdfeb079cc3 in -next).
I'm not sure exactly why this would cause trouble, but I suspect it has something to do w/ the cable-detect OTG to host-hub switch on the HiKey.
Anyway, I just wanted to raise this with you so it can get sorted out before that patch hits mainline.
thanks -john
| |