Messages in this thread | | | Subject | Re: [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC | From | Marc Zyngier <> | Date | Fri, 28 Sep 2018 11:40:22 +0100 |
| |
On 27/09/18 18:18, Lina Iyer wrote: > The PDC irqchp can convert a falling edge or level low interrupt to a > rising edge or level high interrupt at the GIC. We just need to setup > the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH > as IRQ_TYPE_EDGE_RISING at the GIC. > > Reported-by: Evan Green <evgreen@chromium.org> > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > --- > drivers/irqchip/qcom-pdc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > index b1b47a40a278..faa7d61b9d6c 100644 > --- a/drivers/irqchip/qcom-pdc.c > +++ b/drivers/irqchip/qcom-pdc.c > @@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type) > break; > case IRQ_TYPE_EDGE_BOTH: > pdc_type = PDC_EDGE_DUAL; > + type = IRQ_TYPE_EDGE_RISING; > break; > case IRQ_TYPE_LEVEL_HIGH: > pdc_type = PDC_LEVEL_HIGH; >
Queued for 4.20, with
Fixes: f55c73aef890 ("irqchip/pdc: Add PDC interrupt controller for QCOM SoCs")
added. Please consider providing these tags in the future.
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |