Messages in this thread | | | Subject | Re: [PATCH net-next] net: dsa: b53: Fix build with B53_SRAB enabled and B53_SERDES=m | From | Florian Fainelli <> | Date | Thu, 27 Sep 2018 12:07:01 -0700 |
| |
On 09/27/2018 03:02 AM, Arnd Bergmann wrote: > When B53_SERDES is a loadable module, a built-in srab driver still > cannot reach it, so the previous fix is incomplete: > > b53_srab.c:(.text+0x3f4): undefined reference to `b53_serdes_init' > drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe64): undefined reference to `b53_serdes_link_state' > drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe74): undefined reference to `b53_serdes_link_set' > drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe88): undefined reference to `b53_serdes_an_restart' > drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea0): undefined reference to `b53_serdes_phylink_validate' > drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea4): undefined reference to `b53_serdes_config' > > Add a Kconfig dependency that forces srab to also be a module > in this case, but allow it to be built-in when serdes is > disabled or built-in. > > Fixes: 7a8c7f5c30f9 ("net: dsa: b53: Fix build with B53_SRAB enabled and not B53_SERDES") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks! -- Florian
| |