Messages in this thread | | | From | Fabio Estevam <> | Date | Wed, 26 Sep 2018 09:02:07 -0300 | Subject | Re: [PATCH v9 4/5] clk: imx: add imx composite clock |
| |
Hi Sascha,
On Wed, Sep 26, 2018 at 3:47 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> It's: > rate = *prate / prediv_value; > rate = rate / div_value;
Yes, this looks correct. Thanks for the feedback.
> To me this looks correct. However, For an unsigned long type we have > DIV_ROUND_UP() with which we do not need any casting. For 64bit code > unsigned long is 64bit anyway which makes the cast a no-op and for 32bit > code there's also no point in exanding the initial 32bit value to 64bit.
That's a good point too.
Thanks
| |