lkml.org 
[lkml]   [2018]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes
From
Date
On 09/25/2018 10:19 AM, Woojung.Huh@microchip.com wrote:
> Hi Florian,
>
>> @@ -1415,6 +1415,9 @@ static int lan78xx_set_wol(struct net_device *netdev,
>> if (wol->wolopts & WAKE_ARP)
>> pdata->wol |= WAKE_ARP;
>>
>> + if (pdata->wol == 0)
>> + return -EINVAL;
>> +
> It will make function return when disabling WOL.

Huh, yes, good point.

> Is there other place handling this scenario?

How do you mean?

>
>> device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts);
>>
>> phy_ethtool_set_wol(netdev->phydev, wol);
>
>
> Thanks.
> Woojung
>


--
Florian

\
 
 \ /
  Last update: 2018-09-25 19:26    [W:0.483 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site