| Subject | Re: [PATCH v4 21/21] tpm: use u32 instead of int for PCR index | From | Jarkko Sakkinen <> | Date | Tue, 25 Sep 2018 17:41:52 +0300 |
| |
On Fri, 2018-09-21 at 16:58 +0300, Tomas Winkler wrote: > The TPM specs defines PCR index a positive number, there is > no reason to use a signed number and it's also a possible security > issue as currently no functions check for a negative index, > which my into a large number when converted to u32. > > Adjust the API to use u32 instead of int in all PCR related > functions. > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
I think I barked something about this in prev version but after giving some thought. I think this a good change (more exact API).
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
|