lkml.org 
[lkml]   [2018]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings
From
Date
Hi Rob,

[]...
>>>>> + rpmhpd_opp_table: opp-table {
>>>>> + compatible = "operating-points-v2-qcom-level";
>>>>> +
>>>>> + rpmhpd_opp_ret: opp1 {
>>>>> + qcom,level = <RPMH_REGULATOR_LEVEL_RETENTION>;
>>>>> + };
>>>>
>>>> I don't see the point in using the OPP binding here when you aren't
>>>> using *any* of the properties from it.
>>>
>>> Yeah, that's the case for now. But there are cases (as Stephen
>>> mentioned earlier [1]) where the voltage values (and maybe other
>>> values like current, etc) would be known and filled in DT. And that's
>>> why we all agreed to use OPP tables for PM domains as well, as these
>>> are really "operating performance points" of these PM domains.
>>
>> Rob, are you fine with these bindings then?
>
> Okay, my only thought is whether we should just use 'reg' here, or do
> we need 'level' for anything else and should make it common?

I am not quite sure I understood what you are suggesting here :(

\
 
 \ /
  Last update: 2018-09-25 12:25    [W:0.082 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site