lkml.org 
[lkml]   [2018]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] powerpc/traps: merge unrecoverable_exception() and nonrecoverable_exception()
Date
Christophe Leroy <christophe.leroy@c-s.fr> writes:

> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index 6ab66a88db14..4567eeb6524e 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -2090,8 +2082,9 @@ void SPEFloatingPointRoundException(struct pt_regs *regs)
> */
> void unrecoverable_exception(struct pt_regs *regs)
> {
> - printk(KERN_EMERG "Unrecoverable exception %lx at %lx\n",
> - regs->trap, regs->nip);
> + pr_emerg("Unrecoverable exception %lx at %lx (msr=%lx)\n",
> + regs->trap, regs->nip, regs->msr);
> + debugger(regs);
> die("Unrecoverable exception", regs, SIGABRT);

die() already calls debugger() if the trap is != 0x100.

I don't think we want to call it twice?

cheers

\
 
 \ /
  Last update: 2018-09-25 03:30    [W:0.046 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site