Messages in this thread | | | Subject | Re: [PATCH net-next v6 02/23] zinc: introduce minimal cryptography library | From | Joe Perches <> | Date | Tue, 25 Sep 2018 13:05:06 -0700 |
| |
On Tue, 2018-09-25 at 21:43 +0200, Jason A. Donenfeld wrote: > On Tue, Sep 25, 2018 at 8:33 PM Joe Perches <joe@perches.com> wrote: > > I think the -Dpr_fmt is especially odd and not > > really acceptable as it not used anywhere else > > in the kernel. > > There are about 2000 cases in the kernel of the same '#define > pr_fmt...' being pasted into the top of the file, which seems a bit > cumbersome. Rather than having to paste that into each and every file > that I pr_err from,
As far as I can tell, zinc doesn't use pr_err, just pr_info in all the selftest blocks which are only used when DEBUG is #defined.
Perhaps all the pr_info uses should use pr_debug instead as well as dynamic debugging which already optionally adds KBUILD_MODINFO.
> why can't I just do this from the makefile, since > I want that same pr_fmt to copy the whole directory?
Ideally all of those
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
uses will be removed one day soon and the default will change.
https://lore.kernel.org/patchwork/cover/904507/
This slightly odd use might complicate that.
| |